Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import spring-boot-starter-parent BOM #1457

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Import spring-boot-starter-parent BOM #1457

merged 3 commits into from
Oct 30, 2023

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Oct 30, 2023

Fixes jhipster/generator-jhipster#23883.

Before this change, running the following in jhipster-framework pulls in Spring Framework 6.0.11:

$ mvn dependency:tree | grep org.springframework:
[INFO] |  \- org.springframework:spring-webmvc:jar:6.0.11:compile
[INFO] |     \- org.springframework:spring-expression:jar:6.0.11:compile
[INFO] |  \- org.springframework:spring-webflux:jar:6.0.11:compile
[INFO] |  +- org.springframework:spring-core:jar:6.0.11:compile
[INFO] |  |  \- org.springframework:spring-jcl:jar:6.0.11:compile
[INFO] |  +- org.springframework:spring-beans:jar:6.0.11:compile
[INFO] +- org.springframework:spring-context-support:jar:6.0.11:compile
[INFO] |  \- org.springframework:spring-context:jar:6.0.11:compile
[INFO] |  +- org.springframework:spring-aop:jar:6.0.11:compile
[INFO] |  |  \- org.springframework:spring-jdbc:jar:6.0.11:compile
[INFO] |  |  \- org.springframework:spring-orm:jar:6.0.11:compile
[INFO] |  \- org.springframework:spring-aspects:jar:6.0.11:compile
[INFO] |  +- org.springframework:spring-test:jar:6.0.11:test

After this change, it pulls in the correct version:

$ mvn dependency:tree | grep org.springframework:
[INFO] |  \- org.springframework:spring-webmvc:jar:6.0.13:compile
[INFO] |     \- org.springframework:spring-expression:jar:6.0.13:compile
[INFO] |  \- org.springframework:spring-webflux:jar:6.0.13:compile
[INFO] |  +- org.springframework:spring-core:jar:6.0.13:compile
[INFO] |  |  \- org.springframework:spring-jcl:jar:6.0.13:compile
[INFO] |  +- org.springframework:spring-beans:jar:6.0.13:compile
[INFO] +- org.springframework:spring-context-support:jar:6.0.13:compile
[INFO] |  \- org.springframework:spring-context:jar:6.0.13:compile
[INFO] |  +- org.springframework:spring-aop:jar:6.0.13:compile
[INFO] |  |  \- org.springframework:spring-jdbc:jar:6.0.13:compile
[INFO] |  |  \- org.springframework:spring-orm:jar:6.0.13:compile
[INFO] |  \- org.springframework:spring-aspects:jar:6.0.13:compile
[INFO] |  +- org.springframework:spring-test:jar:6.0.13:test
[INFO] |  \- org.springframework:spring-web:jar:6.0.13:compile
[INFO] |  \- org.springframework:spring-tx:jar:6.0.13:compile

@DanielFran
Copy link
Member

@mraible I pushed some changes so we can continue overwriting spring-boot dependencies with the version we defined in jhipster-dependencies.

@mraible
Copy link
Contributor Author

mraible commented Oct 30, 2023

@DanielFran Looks good to me. The results are the same.

@mraible mraible merged commit 80f1494 into main Oct 30, 2023
5 of 8 checks passed
@mraible mraible deleted the spring-boot-parent-bom branch October 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated maven project uses 3.1.4 but incorrectly pulls springframework 6.0.11.
2 participants