Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct specification to QueryService #374

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

egvimo
Copy link
Contributor

@egvimo egvimo commented Jul 9, 2021

This would allow to use the distinct method in the generated EntityQueryService.

So this

Specification<ENTITY> specification = Specification.where(null);

would result in this

Specification<ENTITY> specification = Specification.where(distinct(false));

So the queries would stay the same but it could be changed to a distinct query.

With a little tweaking this boolean Flag could be provided via Criteria class, so it could be queried from the API.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021

CLA assistant check
All committers have signed the CLA.

@egvimo
Copy link
Contributor Author

egvimo commented Aug 9, 2021

Are the tests failing because of my change? Locally I can compile this.

@DanielFran
Copy link
Member

@egvimo Can you rebase with main? We had some issues last weeks and now it seems ok...

@mshima mshima closed this Aug 9, 2021
@mshima mshima reopened this Aug 9, 2021
@egvimo
Copy link
Contributor Author

egvimo commented Aug 10, 2021

@DanielFran Done. Now the workflows are waiting for approval.

@DanielFran DanielFran merged commit bca9d00 into jhipster:main Aug 10, 2021
@DanielFran
Copy link
Member

Thanks @egvimo for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants