Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop bundles. #74

Merged
merged 12 commits into from
Oct 5, 2021
Merged

Drop bundles. #74

merged 12 commits into from
Oct 5, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Oct 5, 2021

I don't think bundles are useful anymore.
Reduces package size from 1,5M to 83K.

-rw-r--r--    1 mshima  staff   1,5M  5 Out 10:39 react-jhipster-0.16.2-bundle.tgz
-rw-r--r--    1 mshima  staff    83K  5 Out 10:37 react-jhipster-0.16.2-no-bundle.tgz

Closes #73.
Related to jhipster/generator-jhipster#16527.

@mshima mshima changed the title Drops bundles. Drop bundles. Oct 5, 2021
Copy link
Member

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya the bundle was added when modules were weird and flaky. If it works from soutrce using the webpack setup in the parent app it should be good

@deepu105
Copy link
Member

deepu105 commented Oct 5, 2021

@mshima can we close the other PR in favor of this?

@mshima
Copy link
Member Author

mshima commented Oct 5, 2021

@deepu105 of corse.
I’ve splitted due to the breaking change nature.

@mshima mshima merged commit ea8642f into jhipster:main Oct 5, 2021
@mshima mshima deleted the bundles branch October 5, 2021 16:50
@mshima
Copy link
Member Author

mshima commented Oct 5, 2021

@pascalgrimaud for safety better to bump to v0.17.x due to bundles drop.

@pascalgrimaud
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants