Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading PGN data containing SetUp and FEN tags causes header information to be lost #154

Merged
merged 5 commits into from
Jun 26, 2017
Merged

Conversation

siansell
Copy link
Contributor

With reference to #129.

I have added a couple of tests, but am new to writing JS tests (and GitHub/PRs in general), so please critically review.

@siansell siansell mentioned this pull request Jun 20, 2017
@jhlywa jhlywa merged commit b2650a3 into jhlywa:master Jun 26, 2017
@jhlywa
Copy link
Owner

jhlywa commented Jun 26, 2017

Looks good. Thanks for the PR

@captainsano
Copy link

This bug seems to be occurring in version 0.10.2 for the following pgn headers:

[Event "10th Tal Mem 2016"]
[Site "Moscow RUS"]
[Date "2016.10.06"]
[Round "9"]
[White "Li, Chao"]
[Black "Giri, Anish"]
[Result "1/2-1/2"]
[WhiteElo "2746"]
[BlackElo "2755"]
[ECO "E21"]
[EventDate "2016.10.06"]
[CurrentPosition "8/5N2/R7/4p3/4Pk1p/P3nP2/2r5/6K1 b - - 0 43"]
[SetUp "1"]
[FEN "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"]

@siansell
Copy link
Contributor Author

Yeah, the version pulled down from NPM (0.10.2) hasn't been updated and doesn't include this PR.

@glandre
Copy link

glandre commented Apr 22, 2019

Any ETA for deploying the version containing this Fix to NPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants