Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include square to board() output #312

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Include square to board() output #312

merged 3 commits into from
Apr 2, 2022

Conversation

fitztrev
Copy link
Contributor

@fitztrev fitztrev commented Feb 20, 2022

This PR adds the square notation to the board() output.

I was looking for an easy way to find all the squares that a certain type of piece would be on.

@jhlywa
Copy link
Owner

jhlywa commented Feb 26, 2022

@fitztrev This change looks reasonable and should be backwards compatible with any existing code that uses the .board() function. The tests, however, appear to be failing in CI though. Can you tweak the tests and docs before I merge? Thanks

@fitztrev
Copy link
Contributor Author

@jhlywa Absolutely!

  • Fixed tests
  • Updated README docs with new .board() output

@jhlywa jhlywa merged commit 062110c into jhlywa:master Apr 2, 2022
@jhlywa
Copy link
Owner

jhlywa commented Apr 2, 2022

Thanks Trevor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants