Keep track of package the bootstrap theme is from #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us have a `features: bootstrap theme:` block in another package, that we can then include in the current interview. Would previously try to look for a locally referenced bootstrap theme in the current package, i.e. "custom_bootstrap.css" wouldn't work, and you would have to put "docassemble.other_package:custom_bootstrap.css".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us have a
features: bootstrap theme:block in another package, that we can then include in the current interview. Previously, DA would try to look for a locally referenced bootstrap theme in the current package, i.e. "custom_bootstrap.css" wouldn't work, and you would have to put "docassemble.other_package:custom_bootstrap.css".Implemented with
hasattr, since there are a few places thatbootstrap_themecould come from, and checking for it's existence seemed simpler than adding an extra variable that also tracked wherebootstrap_themewas set from.Tested locally and it works as expected.