Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move AnVIL assets #85

Merged
merged 3 commits into from
Mar 16, 2022
Merged

move AnVIL assets #85

merged 3 commits into from
Mar 16, 2022

Conversation

KatherineCox
Copy link
Collaborator

@KatherineCox KatherineCox commented Mar 15, 2022

Closes #67

Moved AnVIL style assets into their own subdirectory within assets. Then if people put other things in assets they won't get clobbered by updates from AnVIL_Template.

Updated sync.yml to point to the subdirectory.

There are a couple of things left in the top level of assets right now since they came from OTTR and I'm not sure where they're being used, and don't want to break things by moving them

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

No spelling errors! 🎉
Comment updated at 2022-03-15 with changes from 9c02307

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

No broken URLs detected! 🎉
Comment updated at 2022-03-15 with changes from 9c02307

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

Re-rendered previews from the latest commit:

Updated at 2022-03-15 with changes from 9c02307

@KatherineCox
Copy link
Collaborator Author

@cansavvy a couple of questions about the files in assets

Are these files ever being used? If so where? When I try "searching" the OTTR_Template repo, GitHub it doesn't find them, but I don't know how thorough that is.

  1. style_coursera.css - no search results
  2. toc_close.css - no search results
  3. hideOutput.js - I see it in <script> tags that are commented out.

Wondering if these are leftovers from earlier iterations that are safe to get rid of (both in AnVIL_Template and in OTTR_Template)? Or if they are being used somewhere? I haven't done any coursera or leanpub rendering, so I'm unfamiliar with what's needed there.

@cansavvy
Copy link
Contributor

@cansavvy a couple of questions about the files in assets

Are these files ever being used? If so where? When I try "searching" the OTTR_Template repo, GitHub it doesn't find them, but I don't know how thorough that is.

  1. style_coursera.css - no search results
  2. toc_close.css - no search results
  3. hideOutput.js - I see it in <script> tags that are commented out.

Wondering if these are leftovers from earlier iterations that are safe to get rid of (both in AnVIL_Template and in OTTR_Template)? Or if they are being used somewhere? I haven't done any coursera or leanpub rendering, so I'm unfamiliar with what's needed there.

Those files are all here: https://github.com/jhudsl/OTTR_Template/tree/main/assets

toc_close.css is only needed for Coursera or Leanpub rendering so you can get rid of it if you don't wish to use it.
hideOutput.js I don't know what this is, maybe @carriewright11 knows?
style_coursera.css - is an old version of a file and can be deleted, I'm going to delete it on OTTR_Template now.

@KatherineCox KatherineCox merged commit b0adae3 into main Mar 16, 2022
@avahoffman avahoffman deleted the assets-subdirectory branch August 18, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move AnVIL assets into subdirectory
2 participants