Add handling for GA script file in output.yml #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
commented
Dec 3, 2021
| @@ -106,6 +106,12 @@ jobs: | |||
| curl --fail -s ${base_url}/${line} > ${line} | |||
| done < "$input" | |||
|
|
|||
|
|
|||
| # Get rid of GA Script spec in output yaml | |||
| sed 's/GA_Script.Rhtml,//' _output.yml > output.txt | |||
There was a problem hiding this comment.
sed had trouble going straight to the yml file? Not sure if I missed how to do this more elegantly, I was trying to do this step according to their docs but could get around creating this intermediate txt file. ¯\(ツ)/¯
There was a problem hiding this comment.
yeah, that seems reasonable for now
|
The latest commit did not produce rendering changes. Updated at 2021-12-03 with changes from 81c7b99 |
|
This works, so I'm going to merge it. We should probably think about doing another release soon since this is a un-breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
This will close #337
It's not a very elegant solution, but it works. I just have the
transfer-rendered.ymldelete theGAScript.htmlstring in_output.yml.