Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing latest release and docker image #620

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Mar 1, 2023

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Just running a re-render and checks here to make sure things will be working.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

No spelling errors! 🎉
Comment updated at 2023-03-01 with changes from fa5561f

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

No broken urls! 🎉
Comment updated at 2023-03-01 with changes from fa5561f

@cansavvy
Copy link
Collaborator Author

cansavvy commented Mar 1, 2023

Needed to add @avahoffman 's fix for the checkout@v3 related "not safe" workspace: jhudsl/ottr-reports#16

@avahoffman
Copy link
Contributor

@cansavvy I think the only other place I needed it (besides as part of ottr_reports) is right before the styler. Example

@cansavvy
Copy link
Collaborator Author

cansavvy commented Mar 1, 2023

@cansavvy I think the only other place I needed it (besides as part of ottr_reports) is right before the styler. Example

Yeah I noticed that in the next commit. 😝 I also am seeing an ottrpal bug that I'm gonna try to hot fix 🔥

jhudsl/ottrpal#114

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Re-rendered previews from the latest commit:

Updated at 2023-03-01 with changes from fa5561f

@cansavvy
Copy link
Collaborator Author

cansavvy commented Mar 1, 2023

Yay fixed. And now I'm going to merge and sync

@cansavvy cansavvy merged commit 491b5b9 into main Mar 1, 2023
@cansavvy cansavvy deleted the cansavvy/test-render branch March 1, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants