Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git-config updates part 2 #638

Merged
merged 2 commits into from
May 11, 2023
Merged

Git-config updates part 2 #638

merged 2 commits into from
May 11, 2023

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Seeing some missing config updates on a repository here that a collaborator is using: https://github.com/B7M/Product/actions/runs/4941604660/jobs/8834374525

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

No spelling errors! 🎉
Comment updated at 2023-05-11 with changes from 1ece1c8

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

No broken urls! 🎉
Comment updated at 2023-05-11 with changes from 1ece1c8

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Re-rendered previews from the latest commit:

Updated at 2023-05-11 with changes from 1ece1c8

@cansavvy
Copy link
Collaborator Author

I'm pretty sure we should have caught these the first time around but I think they might be causing some of the problems we are seeing. We need someone outside our org to test it though.

@cansavvy cansavvy requested a review from avahoffman May 11, 2023 00:13
Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Safe!!! lgtm!

@cansavvy cansavvy merged commit a469adc into main May 11, 2023
@cansavvy cansavvy deleted the cansavvy/git-config-part-2 branch May 11, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants