-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wonky html for Google Analytics #640
Conversation
Re-rendered previews from the latest commit:
Updated at 2023-05-22 with changes from bc34d2c |
No broken urls! 🎉 |
No spelling errors! 🎉 |
@KatherineCox Thanks so much for these fixes! I think all looks good!
As far as documentation updating, we will want to add and update this on the ottrproject.org website. Probably as a new header in this file: https://github.com/jhudsl/ottr-website/blob/main/more_features.Rmd Would you be willing/able to file a PR to that repo to make that change? Unfortunately we still hadn't ported over all the wiki changes to the website (this is long been overdue). |
@cansavvy Sure, I can do that! |
Yay! Thanks so much! |
OTTR_Template
I was working on adding Google Analytics to some AnVIL books and noticed a couple of things that could use improvement. This PR:
GA_script.Rhtml
->GA_script.html
(there's no R code in this?)I've tested this in https://github.com/jhudsl/GDSCN_Book_swirl and I'm seeing activity being recorded in Google Analytics dashboard, so it seems to be working correctly.
Wiki
The wiki (https://github.com/jhudsl/OTTR_Template/wiki/Google-Analytics) will also need updating with instructions to include the script in _output.yml (using
in_header
rather thanbefore_body
). I added a new screenshot in this PR, but haven't updated the wiki since this isn't merged yet.Here's a suggestion for new text for step 7: