Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive preview add #729

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Comprehensive preview add #729

merged 1 commit into from
Mar 14, 2024

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What changes are being implemented in this Pull Request?

This change is nearly identical to what I've added to the OTTR Template Website repo: jhudsl/OTTR_Template_Website#61

Was trying to think of a way that a more comprehensive preview could be shown. Because at times I want to check for a change that https://htmlpreview.github.io/ can't handle -- dropdowns and font-awesome icons for example don't get shown.

In this set up a rendered version of the website gets rendered as usually but a copy of it gets zipped up and archived so people could download it.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

No spelling! 🎉
Comment updated at 2024-03-12 with changes from 6652920

Copy link
Contributor

github-actions bot commented Mar 12, 2024

No broken urls! 🎉
Comment updated at 2024-03-12 with changes from 6652920

Copy link
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-03-12 with changes from the latest commit 6652920

@cansavvy cansavvy marked this pull request as ready for review March 13, 2024 17:25
@cansavvy cansavvy requested a review from avahoffman March 13, 2024 17:25
@cansavvy
Copy link
Collaborator Author

Because this is identical to the other PR I'm just gonna merge it.

@cansavvy cansavvy merged commit 2ab83cd into main Mar 14, 2024
7 checks passed
@cansavvy cansavvy deleted the cansavvy/comprehensive-preview branch March 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant