Add selecting elements by namespace (#1811) #1847
Conversation
mo20053444
changed the title
| @@ -162,6 +162,8 @@ private void findElements() { | |||
| byId(); | |||
| else if (tq.matchChomp(".")) | |||
| byClass(); | |||
| else if (tq.toString().endsWith("|*")) | |||
There was a problem hiding this comment.
This is not the right way to do this. The TokenQueue must be consumed token by token. With this implementation, queries like ns|* div (or anything after the namespace wildcard selector) will fail. You will need an appropriate matcher in TokenQueue. I think you could update the current tag matcher.
| @@ -262,6 +264,12 @@ private void byTag() { | |||
| } | |||
| } | |||
|
|
|||
| private void byNamespace() { | |||
There was a problem hiding this comment.
I think I would just extend the byTag method to support this.
| @@ -1319,6 +1319,16 @@ public void testNamespacedElements() { | |||
| assertEquals("html > body > fb|comments", els.get(0).cssSelector()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSelectByNamespace() { | |||
There was a problem hiding this comment.
This should be in SelectorTest, and needs to be more detailed -- e.g. to catch the example I pointed out, and validate other variations work.
|
@jhy Hi Jonathan, hope you had a great holiday season and thank you for your feedback! I will take a look at your comments and make changes accordingly. Thanks! |
This commit enables users to select all elements within a particular namespace by inputting queries like "ns|*".