Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test proxy #2029

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add a test proxy #2029

merged 3 commits into from
Nov 2, 2023

Conversation

jhy
Copy link
Owner

@jhy jhy commented Nov 2, 2023

This adds a local test proxy implementation and some test cases for using Jsoup.connect.proxy().

@jhy
Copy link
Owner Author

jhy commented Nov 2, 2023

The Java 8's failed:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project jsoup: Compilation failure: Compilation failure: 
Error:  /home/runner/work/jsoup/jsoup/src/test/java/org/jsoup/integration/servlets/ProxyServlet.java:[38,56] cannot find symbol
Error:    symbol:   method asIterator()
Error:    location: interface java.util.Enumeration<java.lang.String>
Error:  /home/runner/work/jsoup/jsoup/src/test/java/org/jsoup/integration/servlets/ProxyServlet.java:[41,52] cannot find symbol
Error:    symbol:   method asIterator()
Error:    location: variable values of type java.util.Enumeration<java.lang.String>
Error:  -> [Help 1]

I wonder why the Animal Sniffer for v8 didn't see that?

(And need to figure why Animal Sniffer / Compiler Release 8 didn't catch that.)
@jhy jhy merged commit 45d327f into master Nov 2, 2023
12 checks passed
@jhy jhy deleted the test-proxy branch November 2, 2023 08:26
@jhy
Copy link
Owner Author

jhy commented Nov 4, 2023

(I factored most of the proxy implementation out in #2032 to use Jetty's proxy servlet. Particularly so we could bring in a tunnelling server to implement CONNECT proxying for HTTPS requests.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant