Captured the JSONException that may occur on a Non-Success StatusCode…

… when attempting to Deserialize the HTTPResponse.Content when it is not JSON
jianghaolu · Apr 14, 2016 · 8b015ac · 8b015ac
1 parent 97545e3
commit 8b015ac
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/ClientRuntimes/CSharp/Microsoft.Rest.ClientRuntime.Azure/AzureClientExtensions.cs b/ClientRuntimes/CSharp/Microsoft.Rest.ClientRuntime.Azure/AzureClientExtensions.cs
@@ -599,7 +599,16 @@ private static async Task<AzureOperationResponse<JObject, JObject>> GetRawAsync(
                 statusCode != HttpStatusCode.Created &&
                 statusCode != HttpStatusCode.NoContent)
             {
-                CloudError errorBody = SafeJsonConvert.DeserializeObject<CloudError>(responseContent, client.DeserializationSettings);
+                CloudError errorBody = null;
+                try
+                {
+                    errorBody = SafeJsonConvert.DeserializeObject<CloudError>(responseContent, client.DeserializationSettings);
+                }
+                catch (JsonException)
+                {
+                    // failed to deserialize, return empty body
+                }
+
                 throw new CloudException(string.Format(CultureInfo.InvariantCulture,
                     Resources.LongRunningOperationFailed, statusCode))
                 {