Fix npe and bool type (Azure#21)

jiec-msft · Aug 13, 2021 · 4cc210d · 4cc210d
1 parent b90bde5
commit 4cc210d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/spring-cloud/azext_spring_cloud/_enterprise.py b/src/spring-cloud/azext_spring_cloud/_enterprise.py
@@ -409,7 +409,7 @@ def _create_empty_app(client, resource_group, service, name):
 
 
 def _update_app(assign_endpoint=None):
-    if all(x is None for x in (assign_endpoint)):
+    if assign_endpoint is None:
         return
     properties = models.AppResourceProperties(
        public=assign_endpoint 

diff --git a/src/spring-cloud/azext_spring_cloud/_validators_enterprise.py b/src/spring-cloud/azext_spring_cloud/_validators_enterprise.py
@@ -44,7 +44,8 @@ def validate_git_uri(namespace):
 
 
 def validate_config_file_patterns(namespace):
-    _validate_patterns(namespace.config_file_patterns)
+    if namespace.config_file_patterns:
+        _validate_patterns(namespace.config_file_patterns)
 
 
 def validate_acs_patterns(namespace):

diff --git a/src/spring-cloud/azext_spring_cloud/service_registry.py b/src/spring-cloud/azext_spring_cloud/service_registry.py
@@ -21,11 +21,11 @@ def service_registry_show(cmd, client, service, resource_group):
 
 
 def service_registry_bind(cmd, client, service, resource_group, app):
-    _service_registry_bind_or_unbind_app(cmd, client, service, resource_group, app, True)
+    return _service_registry_bind_or_unbind_app(cmd, client, service, resource_group, app, True)
 
 
 def service_registry_unbind(cmd, client, service, resource_group, app):
-    _service_registry_bind_or_unbind_app(cmd, client, service, resource_group, app, False)
+    return _service_registry_bind_or_unbind_app(cmd, client, service, resource_group, app, False)
 
 
 def _service_registry_bind_or_unbind_app(cmd, client, service, resource_group, app_name, enabled):