fix: 🐛 ignore SVGs in some imports rules (#62)

jimmy-guzman · Nov 5, 2024 · 542d009 · 542d009
1 parent c071453
commit 542d009
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/rules/__snapshots__/imports.spec.ts.snap b/src/rules/__snapshots__/imports.spec.ts.snap
@@ -13,6 +13,7 @@ exports[`should create imports rules 1`] = `
     "never",
     {
       "checkTypedImports": true,
+      "svg": "always",
     },
   ],
   "import-x/first": "error",
@@ -25,7 +26,14 @@ exports[`should create imports rules 1`] = `
   "import-x/no-named-as-default": "error",
   "import-x/no-named-as-default-member": "error",
   "import-x/no-self-import": "error",
-  "import-x/no-unresolved": "error",
+  "import-x/no-unresolved": [
+    "error",
+    {
+      "ignore": [
+        "\\.svg$",
+      ],
+    },
+  ],
   "import-x/no-useless-path-segments": "error",
 }
 `;
diff --git a/src/rules/imports.ts b/src/rules/imports.ts
@@ -5,7 +5,11 @@ import type { Rules } from "../types";
 export const importsRules = {
   ...importX.configs.recommended.rules,
   "import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
-  "import-x/extensions": ["error", "never", { checkTypedImports: true }],
+  "import-x/extensions": [
+    "error",
+    "never",
+    { checkTypedImports: true, svg: "always" },
+  ],
   "import-x/first": "error",
   // ! can't get this rule to work
   "import-x/namespace": "off",
@@ -16,5 +20,6 @@ export const importsRules = {
   "import-x/no-named-as-default": "error",
   "import-x/no-named-as-default-member": "error",
   "import-x/no-self-import": "error",
+  "import-x/no-unresolved": ["error", { ignore: [String.raw`\.svg$`] }],
   "import-x/no-useless-path-segments": "error",
 } satisfies Rules;