fix: 🐛 prevent creating duplicate jest configs

jimmy-guzman · Nov 22, 2024 · 70973da · 70973da
1 parent 378b5d2
commit 70973da
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/src/configs/testing.spec.ts b/src/configs/testing.spec.ts
@@ -3,7 +3,7 @@ import { testingConfig } from "./testing";
 
 describe("testingConfig", () => {
   it("should create default config w/ vitest overrides", async () => {
-    const [, vitest] = await testingConfig({}, false);
+    const [vitest] = await testingConfig({}, false);
 
     expect(vitest?.rules).toStrictEqual(
       expect.objectContaining({

diff --git a/src/configs/testing.ts b/src/configs/testing.ts
@@ -16,11 +16,6 @@ export const testingConfig = async (
   const isJest = framework === "jest" || (autoDetect && hasJest());
 
   return [
-    {
-      files: GLOB_TESTS,
-      name: "jimmy.codes/testing",
-      ...jestPlugin.configs["flat/recommended"],
-    },
     ...(isVitest
       ? [
           {

diff --git a/src/factory.spec.ts b/src/factory.spec.ts
@@ -65,7 +65,6 @@ describe("jimmyDotCodes", () => {
       jimmyDotCodes({ autoDetect: false, testing: { framework: "jest" } }),
     ).resolves.toStrictEqual(
       expect.arrayContaining([
-        expect.objectContaining({ name: "jimmy.codes/testing" }),
         expect.objectContaining({ name: "jimmy.codes/testing/disabled" }),
         expect.objectContaining({ name: "jimmy.codes/testing/jest" }),
         expect.not.objectContaining({ name: "jimmy.codes/testing/vitest" }),
@@ -78,7 +77,6 @@ describe("jimmyDotCodes", () => {
       jimmyDotCodes({ autoDetect: false, testing: true }),
     ).resolves.toStrictEqual(
       expect.arrayContaining([
-        expect.objectContaining({ name: "jimmy.codes/testing" }),
         expect.objectContaining({ name: "jimmy.codes/testing/disabled" }),
         expect.not.objectContaining({ name: "jimmy.codes/testing/jest" }),
         expect.objectContaining({ name: "jimmy.codes/testing/vitest" }),
@@ -95,7 +93,6 @@ describe("jimmyDotCodes", () => {
       }),
     ).resolves.toStrictEqual(
       expect.arrayContaining([
-        expect.objectContaining({ name: "jimmy.codes/testing" }),
         expect.objectContaining({ name: "jimmy.codes/testing/disabled" }),
         expect.objectContaining({ name: "jimmy.codes/testing/jest" }),
         expect.objectContaining({ name: "jimmy.codes/react" }),
@@ -118,7 +115,6 @@ describe("jimmyDotCodes", () => {
       }),
     ).resolves.toStrictEqual(
       expect.arrayContaining([
-        expect.objectContaining({ name: "jimmy.codes/testing" }),
         expect.objectContaining({ name: "jimmy.codes/testing/disabled" }),
         expect.objectContaining({ name: "jimmy.codes/testing/vitest" }),
         expect.objectContaining({ name: "jimmy.codes/react" }),
@@ -220,7 +216,7 @@ describe("jimmyDotCodes", () => {
       await expect(jimmyDotCodes({ autoDetect: true })).resolves.toStrictEqual(
         expect.arrayContaining([
           expect.not.objectContaining({ name: "jimmy.codes/typescript" }),
-          expect.objectContaining({ name: "jimmy.codes/testing" }),
+
           expect.objectContaining({ name: "jimmy.codes/testing/vitest" }),
           expect.not.objectContaining({ name: "jimmy.codes/testing/jest" }),
           expect.not.objectContaining({ name: "jimmy.codes/react" }),
@@ -240,7 +236,7 @@ describe("jimmyDotCodes", () => {
       await expect(jimmyDotCodes({ autoDetect: true })).resolves.toStrictEqual(
         expect.arrayContaining([
           expect.not.objectContaining({ name: "jimmy.codes/typescript" }),
-          expect.objectContaining({ name: "jimmy.codes/testing" }),
+
           expect.not.objectContaining({ name: "jimmy.codes/testing/vitest" }),
           expect.objectContaining({ name: "jimmy.codes/testing/jest" }),
           expect.not.objectContaining({ name: "jimmy.codes/react" }),
@@ -261,7 +257,7 @@ describe("jimmyDotCodes", () => {
       await expect(jimmyDotCodes({ autoDetect: true })).resolves.toStrictEqual(
         expect.arrayContaining([
           expect.not.objectContaining({ name: "jimmy.codes/typescript" }),
-          expect.objectContaining({ name: "jimmy.codes/testing" }),
+
           expect.objectContaining({ name: "jimmy.codes/testing/vitest" }),
           expect.not.objectContaining({ name: "jimmy.codes/testing/jest" }),
           expect.not.objectContaining({ name: "jimmy.codes/react" }),