feat: ✨ enable react/no-object-type-as-default-prop

jimmy-guzman · Nov 3, 2024 · af90a75 · af90a75
1 parent c4da6c5
commit af90a75
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 49 deletions.
diff --git a/package.json b/package.json
@@ -81,10 +81,10 @@
     "@semantic-release/git": "10.0.1",
     "@semantic-release/npm": "12.0.1",
     "@semantic-release/release-notes-generator": "14.0.1",
-    "@tanstack/react-query": "5.59.17",
+    "@tanstack/react-query": "5.59.19",
     "@testing-library/dom": "10.4.0",
     "@testing-library/react": "16.0.1",
-    "@types/node": "22.8.6",
+    "@types/node": "22.8.7",
     "@types/react": "18.3.12",
     "@vitest/coverage-v8": "2.1.4",
     "astro": "4.16.8",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/rules/__snapshots__/react.spec.ts.snap b/src/rules/__snapshots__/react.spec.ts.snap
@@ -261,7 +261,7 @@ exports[`should create react rules 1`] = `
   "react/no-is-mounted": "error",
   "react/no-multi-comp": "off",
   "react/no-namespace": "error",
-  "react/no-object-type-as-default-prop": "off",
+  "react/no-object-type-as-default-prop": "error",
   "react/no-redundant-should-component-update": "error",
   "react/no-render-return-value": "error",
   "react/no-set-state": "off",

diff --git a/src/rules/react.ts b/src/rules/react.ts
@@ -49,7 +49,7 @@ export const reactRules = {
   "react/no-invalid-html-attribute": "error",
   "react/no-multi-comp": "off",
   "react/no-namespace": "error",
-  "react/no-object-type-as-default-prop": "off", // revisit
+  "react/no-object-type-as-default-prop": "error",
   "react/no-redundant-should-component-update": "error",
   "react/no-set-state": "off",
   "react/no-this-in-sfc": "error",