Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax mkdirp dependency to allow newer minimist #857

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

Den-dp
Copy link
Contributor

@Den-dp Den-dp commented Mar 18, 2020

What's Changing and Why

Fixing https://www.npmjs.com/advisories/1179 by relaxing mkdirp versions range to allow 0.5.2 or 0.5.3 which contains a fix as per isaacs/node-mkdirp#7 (comment)

What else might be affected

Nothing

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

Published PR with canary version: 0.9.6-canary.857.681.0

@Den-dp Den-dp mentioned this pull request Mar 18, 2020
4 tasks
@Den-dp
Copy link
Contributor Author

Den-dp commented Mar 18, 2020

😕

Error: Errors in typescript@next for external dependencies:
../../core/types/utils.d.ts(16,3): error TS2536: Type '"class"' cannot be used to index type 'T'.
../../core/types/utils.d.ts(17,3): error TS2536: Type '"constants"' cannot be used to index type 'T'.

    at /home/circleci/jimp/node_modules/dtslint/bin/index.js:190:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/circleci/jimp/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>
error Command failed with exit code 1.

Looks similar to #853

@hipstersmoothie
Copy link
Collaborator

Taking a look now

@hipstersmoothie
Copy link
Collaborator

@crutchcorn if you could take a look at this that would be awesome

@crutchcorn crutchcorn mentioned this pull request Mar 18, 2020
4 tasks
@crutchcorn
Copy link
Member

Please rebase on master - the blocking test-type issue has now been resolved :)

Fixing https://www.npmjs.com/advisories/1179 by relaxing mkdirp versions range to allow 0.5.2 or 0.5.3 which contains a fix as per isaacs/node-mkdirp#7 (comment)
@Den-dp Den-dp force-pushed the fix/mkdirp-minimist branch from f3da5a5 to 002d4f4 Compare March 18, 2020 17:23
@Den-dp
Copy link
Contributor Author

Den-dp commented Mar 18, 2020

All checks have passed 😃

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 18, 2020
@hipstersmoothie hipstersmoothie merged commit 8e8e352 into jimp-dev:master Mar 18, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.9.6 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Mar 18, 2020
@karlhorky
Copy link

karlhorky commented Mar 19, 2020

Opened a PR to upgrade to this version in potrace:

tooolbox/node-potrace#5

This will also fix Gatsby projects if it's released as a minor or patch, since gatsby-plugin-sharp and gatsby-transformer-sharp depend on potrace@^2.1.2:


Update: Released in potrace@2.1.5! (see tooolbox/node-potrace#5 (comment))

Gatsby pull request: gatsbyjs/gatsby#22434

Update 2: Ah, Gatsby was actually upgraded separately, in this pull request. These patch versions are the versions to look for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants