Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing plugins #866

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Added missing plugins #866

merged 1 commit into from
Mar 28, 2020

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Mar 27, 2020

What's Changing and Why

Previously, the plugin code was not exporting the following plugins themselves:

  • circle
  • fisheye
  • shadow
  • threshold

This PR updates this to do just that. This fixes #864

What else might be affected

Because we're technically adding new functionality (our typings were wrong before, this just wasn't present on jimp before), we could make this a minor release or we could just make it a patch release and say that lack of export was a bug

Tasks

None of the tasks were required

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.9.8-canary.866.767.0

✨ Test out this PR locally via:

npm install @jimp/cli@0.9.8-canary.866.767.0
npm install @jimp/core@0.9.8-canary.866.767.0
npm install @jimp/custom@0.9.8-canary.866.767.0
npm install jimp@0.9.8-canary.866.767.0
npm install @jimp/plugin-blit@0.9.8-canary.866.767.0
npm install @jimp/plugin-blur@0.9.8-canary.866.767.0
npm install @jimp/plugin-circle@0.9.8-canary.866.767.0
npm install @jimp/plugin-color@0.9.8-canary.866.767.0
npm install @jimp/plugin-contain@0.9.8-canary.866.767.0
npm install @jimp/plugin-cover@0.9.8-canary.866.767.0
npm install @jimp/plugin-crop@0.9.8-canary.866.767.0
npm install @jimp/plugin-displace@0.9.8-canary.866.767.0
npm install @jimp/plugin-dither@0.9.8-canary.866.767.0
npm install @jimp/plugin-fisheye@0.9.8-canary.866.767.0
npm install @jimp/plugin-flip@0.9.8-canary.866.767.0
npm install @jimp/plugin-gaussian@0.9.8-canary.866.767.0
npm install @jimp/plugin-invert@0.9.8-canary.866.767.0
npm install @jimp/plugin-mask@0.9.8-canary.866.767.0
npm install @jimp/plugin-normalize@0.9.8-canary.866.767.0
npm install @jimp/plugin-print@0.9.8-canary.866.767.0
npm install @jimp/plugin-resize@0.9.8-canary.866.767.0
npm install @jimp/plugin-rotate@0.9.8-canary.866.767.0
npm install @jimp/plugin-scale@0.9.8-canary.866.767.0
npm install @jimp/plugin-shadow@0.9.8-canary.866.767.0
npm install @jimp/plugin-threshold@0.9.8-canary.866.767.0
npm install @jimp/plugins@0.9.8-canary.866.767.0
npm install @jimp/test-utils@0.9.8-canary.866.767.0
npm install @jimp/bmp@0.9.8-canary.866.767.0
npm install @jimp/gif@0.9.8-canary.866.767.0
npm install @jimp/jpeg@0.9.8-canary.866.767.0
npm install @jimp/png@0.9.8-canary.866.767.0
npm install @jimp/tiff@0.9.8-canary.866.767.0
npm install @jimp/types@0.9.8-canary.866.767.0
npm install @jimp/utils@0.9.8-canary.866.767.0
# or 
yarn add @jimp/cli@0.9.8-canary.866.767.0
yarn add @jimp/core@0.9.8-canary.866.767.0
yarn add @jimp/custom@0.9.8-canary.866.767.0
yarn add jimp@0.9.8-canary.866.767.0
yarn add @jimp/plugin-blit@0.9.8-canary.866.767.0
yarn add @jimp/plugin-blur@0.9.8-canary.866.767.0
yarn add @jimp/plugin-circle@0.9.8-canary.866.767.0
yarn add @jimp/plugin-color@0.9.8-canary.866.767.0
yarn add @jimp/plugin-contain@0.9.8-canary.866.767.0
yarn add @jimp/plugin-cover@0.9.8-canary.866.767.0
yarn add @jimp/plugin-crop@0.9.8-canary.866.767.0
yarn add @jimp/plugin-displace@0.9.8-canary.866.767.0
yarn add @jimp/plugin-dither@0.9.8-canary.866.767.0
yarn add @jimp/plugin-fisheye@0.9.8-canary.866.767.0
yarn add @jimp/plugin-flip@0.9.8-canary.866.767.0
yarn add @jimp/plugin-gaussian@0.9.8-canary.866.767.0
yarn add @jimp/plugin-invert@0.9.8-canary.866.767.0
yarn add @jimp/plugin-mask@0.9.8-canary.866.767.0
yarn add @jimp/plugin-normalize@0.9.8-canary.866.767.0
yarn add @jimp/plugin-print@0.9.8-canary.866.767.0
yarn add @jimp/plugin-resize@0.9.8-canary.866.767.0
yarn add @jimp/plugin-rotate@0.9.8-canary.866.767.0
yarn add @jimp/plugin-scale@0.9.8-canary.866.767.0
yarn add @jimp/plugin-shadow@0.9.8-canary.866.767.0
yarn add @jimp/plugin-threshold@0.9.8-canary.866.767.0
yarn add @jimp/plugins@0.9.8-canary.866.767.0
yarn add @jimp/test-utils@0.9.8-canary.866.767.0
yarn add @jimp/bmp@0.9.8-canary.866.767.0
yarn add @jimp/gif@0.9.8-canary.866.767.0
yarn add @jimp/jpeg@0.9.8-canary.866.767.0
yarn add @jimp/png@0.9.8-canary.866.767.0
yarn add @jimp/tiff@0.9.8-canary.866.767.0
yarn add @jimp/types@0.9.8-canary.866.767.0
yarn add @jimp/utils@0.9.8-canary.866.767.0

@hipstersmoothie
Copy link
Collaborator

Good to merge?

@crutchcorn
Copy link
Member Author

Yup! Sorry I missed this beforehand

@hipstersmoothie hipstersmoothie merged commit 7aae562 into jimp-dev:master Mar 28, 2020
@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 28, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.9.8 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type error in recent release of @jimp/plugins
2 participants