api.exchangerate.io needs access_key to access the query #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwangdev
force-pushed
the
master
branch
2 times, most recently
from
cd59e0c
to
7f5e0ee
Compare
jkaving
reviewed
Dec 8, 2021
|
|
||
| uri = URI("https://api.exchangeratesapi.io/latest?base=#{base}") | ||
| uri = URI("http://api.exchangeratesapi.io/v1/latest?access_key=#{access_key}") |
There was a problem hiding this comment.
I guess the change to HTTP is because exchangeratesapi.io now only supports HTTPS for paid plans.
| @@ -6,11 +6,14 @@ | |||
| data = JSON.parse(File.read('data.json')) | |||
| base = data['base'] | |||
| units = data['units'] | |||
| access_key = "5413e55dd50ddb2555c63a9cd57c0306" | |||
There was a problem hiding this comment.
The access key should be made configurable (like in #26).
Comment on lines
+17
to
+29
| def get_currency_rate_with_symble(base, *targets) | ||
| default_base = 'EUR' | ||
| access_key = "5413e55dd50ddb2555c63a9cd57c0306" | ||
| uri = URI("http://api.exchangeratesapi.io/v1/latest?access_key=#{access_key}") | ||
| result = JSON.parse(Net::HTTP.get(uri)) | ||
| res = Hash['success' => result['success'], 'base' => base, 'timestamp' => result['timestamp']] | ||
| rates = Hash[] | ||
| targets.each do | target | | ||
| rates[target] = result['rates'][target] * result['rates'][default_base] / result['rates'][base] | ||
| end | ||
| res['rates'] = rates | ||
| return res | ||
| end |
There was a problem hiding this comment.
I guess this is because the free plan for exchangeratesapi.io always uses EUR as the base currency.
| @@ -13,6 +13,22 @@ | |||
| base = data['base'] | |||
| units = data['units'] | |||
|
|
|||
|
|
|||
| def get_currency_rate_with_symble(base, *targets) | |||
There was a problem hiding this comment.
get_currency_rate_with_symbol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided a convenient way to adjust this api.exchangerate.io API change.