Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix weird host assignemnt in k8s yaml #6051

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 20, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (482639a) 77.02% compared to head (af03861) 77.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
+ Coverage   77.02%   77.04%   +0.02%     
==========================================
  Files         145      145              
  Lines       13901    13879      -22     
==========================================
- Hits        10707    10693      -14     
+ Misses       3194     3186       -8     
Flag Coverage Δ
jina 77.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/orchestrate/deployments/config/k8s.py 100.00% <100.00%> (ø)
...deployments/config/k8slib/kubernetes_deployment.py 84.31% <100.00%> (+21.30%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM merged commit 23acd11 into master Sep 21, 2023
@JoanFM JoanFM deleted the fix-host-assingment-gateway-k8s branch September 21, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant