Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): free allocated CStrings #6054

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

thechampagne
Copy link
Contributor

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (3652cfd) 77.01% compared to head (40585fc) 77.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6054      +/-   ##
==========================================
+ Coverage   77.01%   77.05%   +0.03%     
==========================================
  Files         145      145              
  Lines       13879    13879              
==========================================
+ Hits        10689    10694       +5     
+ Misses       3190     3185       -5     
Flag Coverage Δ
jina 77.05% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ina/serve/runtimes/gateway/graph/topology_graph.py 71.81% <0.00%> (+0.81%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM
Copy link
Member

JoanFM commented Sep 25, 2023

Thank you for the contribution, may I ask how did you spot this error? there may be others in the code.

Thanks

@JoanFM
Copy link
Member

JoanFM commented Sep 26, 2023

Would this also require change?

LogLevel                 = C.CString(raftDefaultConfig.LogLevel)

@JoanFM JoanFM changed the title fix memory leak fix(consensus): free allocated CStrings Sep 26, 2023
@JoanFM JoanFM merged commit 195d376 into jina-ai:master Sep 26, 2023
@thechampagne
Copy link
Contributor Author

Would this also require change?

Yes it should be freed, totally forgot it.

@thechampagne
Copy link
Contributor Author

Thank you for the contribution, may I ask how did you spot this error? there may be others in the code.

Thanks

Reading the code 💀 not all of it for sure.

@JoanFM JoanFM mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants