Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix topology schema validation #6057

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: fix topology schema validation #6057

merged 1 commit into from
Sep 26, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 26, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b168e4c) 76.85% compared to head (3a7f48d) 75.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6057      +/-   ##
==========================================
- Coverage   76.85%   75.35%   -1.51%     
==========================================
  Files         145      145              
  Lines       13879    13889      +10     
==========================================
- Hits        10667    10466     -201     
- Misses       3212     3423     +211     
Flag Coverage Δ
jina 75.35% <0.00%> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ina/serve/runtimes/gateway/graph/topology_graph.py 68.33% <0.00%> (-3.48%) ⬇️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the fix-topology-validation branch from b08d2a5 to 3a7f48d Compare September 26, 2023 13:09
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Sep 26, 2023
@JoanFM JoanFM merged commit fbfd305 into master Sep 26, 2023
124 of 128 checks passed
@JoanFM JoanFM deleted the fix-topology-validation branch September 26, 2023 13:56
@JoanFM JoanFM mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant