Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with same doc type in spawned processes #6062

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 29, 2023

When multiple Executors inside a Flow have the same model and they are used as docker containers or using JINA_MP_START_METHOD=spawn there will be an exception when served via HTTP.

This PR fixes this issue by making sure that only one model instance is considered for the same model name.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (67c83c2) 76.05% compared to head (1c4b9d3) 75.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
- Coverage   76.05%   75.94%   -0.12%     
==========================================
  Files         145      145              
  Lines       13916    13925       +9     
==========================================
- Hits        10584    10575       -9     
- Misses       3332     3350      +18     
Flag Coverage Δ
jina 75.94% <30.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% <0.00%> (ø)
jina/serve/stream/__init__.py 84.65% <37.50%> (-2.85%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/M area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Sep 29, 2023
@JoanFM JoanFM merged commit 31e0c9a into master Sep 29, 2023
125 of 129 checks passed
@JoanFM JoanFM deleted the fix-issue branch September 29, 2023 10:13
@JoanFM JoanFM mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant