Skip to content

Commit

Permalink
Merge pull request astra-sim#263 from jinsun-yoo/ns3_features
Browse files Browse the repository at this point in the history
ns3 features: default value for comm_group & ASTRA-sim logger
  • Loading branch information
jinsun-yoo authored Nov 6, 2024
2 parents 8be99b6 + b45a34c commit 1e35b05
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion astra-sim/network_frontend/ns3/AstraSimNetwork.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <thread>
#include <unistd.h>
#include <vector>
#include "astra-sim/common/Logging.hh"

using namespace std;
using namespace ns3;
Expand Down Expand Up @@ -142,8 +143,9 @@ string workload_configuration;
string system_configuration;
string network_configuration;
string memory_configuration;
string comm_group_configuration;
string comm_group_configuration = "empty";
string logical_topology_configuration;
string logging_configuration = "empty";
int num_queues_per_dim = 1;
double comm_scale = 1;
double injection_scale = 1;
Expand Down Expand Up @@ -200,6 +202,9 @@ void parse_args(int argc, char* argv[]) {
cmd.AddValue("logical-topology-configuration",
"Logical topology configuration file",
logical_topology_configuration);
cmd.AddValue("logging-configuration",
"Logging configuration file",
logging_configuration);

cmd.AddValue("num-queues-per-dim", "Number of queues per each dimension",
num_queues_per_dim);
Expand All @@ -219,6 +224,7 @@ int main(int argc, char* argv[]) {

// Read network config and find logical dims.
parse_args(argc, argv);
AstraSim::LoggerFactory::init(logging_configuration);
read_logical_topo_config(logical_topology_configuration, logical_dims);

// Setup network & System layer.
Expand Down

0 comments on commit 1e35b05

Please sign in to comment.