Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug sub태그 default태그로 머지 시도시 실종됨 #492

Merged
merged 3 commits into from
Jun 8, 2023
Merged

bug sub태그 default태그로 머지 시도시 실종됨 #492

merged 3 commits into from
Jun 8, 2023

Conversation

nyj001012
Copy link
Contributor

개요

서브 태그를 디폴트 태그로 변경했을 때, 해당 책의 디폴트 태그를 조회하면 그 데이터가 보이지 않음

작업 사항

  • bookInfoId를 받을 때 request body가 아닌 parameter로 받아 옴
  • (추가) bookInfoId 유효성 검사 시, null, undefined, 0은 DB를 거치지 않고 바로 false를 반환하게 함

변경점

  • tag controller
  • tag service

목적

스크린샷 (optional)

nyj001012 added 2 commits June 6, 2023 07:59
@nyj001012
bug(tag): bookInfoId를 가져올 때 params에서 가져오게 함
2cf8aa5 
bookInfoId를 가져올 때 request body가 아닌 params에서 가져오게 함
@nyj001012
feat(tag): bookInfoId 유효성 검사에서 null, undefined, 0인 경우 추가
f1b788d 
bookInfoId 유효성 검사에서 null, undefined, 0인 경우, DB를 거치지 않고 바로 false를 반환하게 함
@nyj001012 nyj001012 added the bug Something isn't working label Jun 5, 2023
@nyj001012 nyj001012 self-assigned this Jun 5, 2023
@nyj001012 nyj001012 linked an issue Jun 5, 2023 that may be closed by this pull request
sub태그 default태그로 머지 시도시 실종됨 #491
Closed
@nyj001012 nyj001012 marked this pull request as draft June 5, 2023 23:05
@nyj001012
chore(tag): merge 시 request param들 Number 형으로 명시적 형변환
3c3d712 
merge 시 request param들 Number 형으로 명시적 형변환
@nyj001012 nyj001012 marked this pull request as ready for review June 5, 2023 23:07
@nyj001012 nyj001012 changed the title sub태그 default태그로 머지 시도시 실종됨 bug sub태그 default태그로 머지 시도시 실종됨 Jun 5, 2023
cjho0316
cjho0316 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyj001012 nyj001012 merged commit c4e3296 into develop Jun 8, 2023
@nyj001012 nyj001012 deleted the 491-sub태그-default태그로-머지-시도시-실종됨 branch June 8, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjho0316 cjho0316 cjho0316 approved these changes

@not-using not-using Awaiting requested review from not-using

@chanhihi chanhihi Awaiting requested review from chanhihi

Assignees

@nyj001012 nyj001012

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sub태그 default태그로 머지 시도시 실종됨
2 participants
@nyj001012 @cjho0316