Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

496 patch tagsbookinfoidmerge body 중 supertagid null 값 허용안함 #498

Conversation

nyj001012
Copy link
Contributor

개요

superTagId에 null을 허용했을 때, DB에는 superTagId 값이 0으로 적용됨

작업 사항

  • superTagId null 검사할 때, === null 대신 === 0 사용
  • (추가) 디폴트 태그로의 병합에서 컨트롤러의 리턴 값으로 superTagId: 0이 반환되던 것을 superTagId: defaultTagId로 수정

변경점

  • 컨트롤러
  • 서비스

목적

스크린샷 (optional)

superTagId를 Number로 형변환하여 사용 시, null을 검사할 때 0인지 확인하는 방법을 적용
컨트롤러에서 default tag id 반환 시, 0이 반환되지 않고 해당 default tag id가 반환되도록 수정
@nyj001012 nyj001012 added the bug Something isn't working label Jun 10, 2023
@nyj001012 nyj001012 requested a review from not-using June 10, 2023 00:13
@nyj001012 nyj001012 self-assigned this Jun 10, 2023
@nyj001012 nyj001012 requested a review from cjho0316 June 10, 2023 00:31
Copy link
Contributor

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyj001012 nyj001012 merged commit c6a4f3d into develop Jun 14, 2023
@scarf005 scarf005 deleted the 496-patch-tagsbookinfoidmerge-body-중-supertagid-null-값-허용안함 branch June 20, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATCH /tags/{bookInfoId}/merge body 중 superTagId null 값 허용안함
2 participants