-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 환경 변수를 zod로 파싱 #530
Merged
The head ref may contain hidden characters: "env-\uBAA8\uB450-zod\uB85C-\uD30C\uC2F1"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typeRoots`에 명시적으로 포함
process.env 처리 위치를 통일하기 위한 경로입니다.
.env와 혼동 가능성을 줄이기 위해 config로 이름을 변경했습니다.
scarf005
commented
Jun 24, 2023
YeonSeong-Lee
approved these changes
Jun 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
일시적인 현상이었던 것 같습니다. PR 이전과 비교해 정상 동작하는 것을 확인했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
#485 프로젝트의 일부입니다.
작업 사항
src/config
를 단일 진리의 원천으로 하여 여러 곳에서 중복된 키를 정의한 것을 줄였습니다.목적
env키가 존재하지 않거나 올바르지 않을 경우 (예: REDIRECT_URL이 URL이 아님) 런타임에 문제가 발생하거나, 조용히 잊혀져 문제를 찾는 데 어려움을 겪을 수 있습니다.