Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 회원가입시 이메일과 비밀번호 보안 개선 #540

Merged
merged 5 commits into from
Jul 12, 2023
Merged

feat: 회원가입시 이메일과 비밀번호 보안 개선 #540

merged 5 commits into from
Jul 12, 2023

Conversation

middlefitting
Copy link
Member

개요

  • 회원가입 보안을 개선합니다.

작업 사항

  • 인트라 회원가입시 비밀번호를 UUID를 통해 랜덤값으로 설정
  • 기본 회원가입시 @student.42seoul.kr 를 금지하도록 설정

@middlefitting middlefitting linked an issue Jun 28, 2023 that may be closed by this pull request
인트라 회원가입시 이메일과 비밀번호를 랜덤 암호로 변경 #525
Closed
@middlefitting middlefitting marked this pull request as draft June 28, 2023 05:44
@middlefitting middlefitting changed the title 회원가입 개선 feat: 회원가입 개선 Jun 28, 2023
@middlefitting middlefitting marked this pull request as ready for review July 4, 2023 15:19
nyj001012
nyj001012 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 changed the title feat: 회원가입 개선 feat: 회원가입시 이메일과 비밀번호 보안 개선 Jul 5, 2023
scarf005
scarf005 requested changes Jul 11, 2023
View reviewed changes
backend/src/auth/auth.controller.ts Outdated Show resolved Hide resolved
backend/package.json Outdated Show resolved Hide resolved
@scarf005 scarf005 mentioned this pull request Jul 11, 2023
Closed
middlefitting and others added 3 commits July 12, 2023 15:04
@middlefitting @scarf005
refactor(auth.controller): change import crypto to node:crypto
dadaa47 
Co-authored-by: scarf <greenscarf005@gmail.com>
@middlefitting @scarf005
build(package.json): remove uuid
1e348e4 
Co-authored-by: scarf <greenscarf005@gmail.com>
@middlefitting @scarf005
fix(users.controller): invalid exception code
1bf0834 
Co-authored-by: scarf <greenscarf005@gmail.com>
scarf005
scarf005 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 merged commit 3e7c219 into develop Jul 12, 2023
@scarf005 scarf005 deleted the 회원가입_개선 branch July 12, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

@nyj001012 nyj001012 nyj001012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

인트라 회원가입시 이메일과 비밀번호를 랜덤 암호로 변경
3 participants
@middlefitting @nyj001012 @scarf005