Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: review 스키마 타입 검증 완화, disabled 필드 기본값 추가 #549

Merged
merged 1 commit into from
Jul 8, 2023
Merged

fix: review 스키마 타입 검증 완화, disabled 필드 기본값 추가 #549

merged 1 commit into from
Jul 8, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jul 6, 2023 •
edited
Loading

개요

개발자 도구 - 집현전 - http:__localhost:4242_mypage_01

작업 사항

// req.params
{
  "limit": "5",
  "page": "0",
  "isMyReview": "true"
}

프론트 요청 확인 결과

  • 필드가 모두 string 타입으로 들어오고 있으나 백엔드에서는 number 또는 boolean을 기대하고 있어 문제가 발생했습니다.
  • disabled 필드의 기본값 부분이 누락되어 있었습니다.

@scarf005 scarf005 requested a review from not-using July 6, 2023 11:34
@scarf005 scarf005 linked an issue Jul 6, 2023 that may be closed by this pull request
reviews/my-reviews GET 요청 인자 체크 오류 #546
Closed
@scarf005 scarf005 force-pushed the 546-reviewsmy-reviews-get-요청-인자-체크-오류 branch 2 times, most recently from df1ff0c to fc33439 Compare July 6, 2023 14:38
@scarf005 scarf005 force-pushed the 546-reviewsmy-reviews-get-요청-인자-체크-오류 branch from fc33439 to 65f63a3 Compare July 6, 2023 14:39
nyj001012
nyj001012 approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 merged commit 243e7bc into develop Jul 8, 2023
@scarf005 scarf005 deleted the 546-reviewsmy-reviews-get-요청-인자-체크-오류 branch July 8, 2023 04:13
@scarf005 scarf005 mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyj001012 nyj001012 nyj001012 approved these changes

@not-using not-using Awaiting requested review from not-using

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reviews/my-reviews GET 요청 인자 체크 오류
2 participants
@scarf005 @nyj001012