Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 태그 관리자 용의 api 분리 #590

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

nyj001012
Copy link
Contributor

개요

태그 관리자 용의 api와 일반 사용자 용 api로 분리

작업 사항

/api/tags/{superTagId}/sub GET을

  • 일반 사용자 용: /api/tags/{superTagId}/sub
  • 태그 관리자 용: /api/tags/manage/{superTagId}/sub

로 분리하였습니다. 내부 함수 로직은 같으나, 추후 태그 관리자나 일반 사용자에 따라 로직의 변경이 일어날 시, 변경 사항 적용을 용이하게 하기 위해 위와 같이 작업하였습니다.

@nyj001012 nyj001012 added enhancement New feature or request proposal labels Jul 18, 2023
@nyj001012 nyj001012 self-assigned this Jul 18, 2023
@nyj001012 nyj001012 linked an issue Jul 18, 2023 that may be closed by this pull request
@scarf005 scarf005 requested review from scarf005 and jimin52 July 23, 2023 01:13
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

태그 관리자 용의 api와 일반 사용자 용 api로 분리
@scarf005 scarf005 force-pushed the 581-태그-상세-페이지-api-요청 branch from a847edf to f91d858 Compare July 23, 2023 01:17
@scarf005 scarf005 temporarily deployed to development July 23, 2023 01:17 — with GitHub Actions Inactive
@nyj001012 nyj001012 merged commit d57449d into develop Jul 23, 2023
@scarf005 scarf005 deleted the 581-태그-상세-페이지-api-요청 branch July 23, 2023 01:19
nyj001012 added a commit that referenced this pull request Jul 31, 2023
태그 관리자 용의 api와 일반 사용자 용 api로 분리
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

태그 상세 페이지 API 요청.
2 participants