Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
scarf005
requested changes
Aug 12, 2023
updatedAt 필드의 값을 Date->string 으로 처리 Co-authored-by: scarf <greenscarf005@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
stock api 에 ts-rest 적용하여 리팩토링
작업 사항
contract 작성
controller 작성
service 작성
error 처리
질문
재고조회(search) api(page와 limit 외에 별도의 인자가 없습니다) 에서 발생할 수 있는 에러에 관한 조언을 구합니다.
또한 재고조회에서 updatedAt 값이 zod에서 타입변환하는데 오류를 보이고 있습니다.
updatedAt: '2023-03-12-16:19:26' 와 같은 형식으로 조회되는데 %d와 %T 사이에 있는 "-"가 문제를 일으키는게 아닌가하여 entity/entities/VStock.ts 에서 queryBuilder 부분을 수정해보았으나 반환되는 값은 그대로여서 이 부분에 대한 조언도 구합니다.
수정을 위한 PR로 피드백 부탁드립니다.