Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 로그아웃시 access_token 삭제 #674

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: 로그아웃시 access_token 삭제 #674

merged 1 commit into from
Aug 15, 2023

Conversation

scarf005
Copy link
Member

개요

원인

로그아웃시 쿠키를 설정할 때 도메인(42library.kr/localhost)과 스킴(http/https)이 일치하지 않아 동일한 쿠키로 간주되지 않았습니다.

내용

쿠키 설정 및 삭제시 동일한 도메인과 스킴을 사용하도록 변경했습니다.

참고 링크

@scarf005 scarf005 requested a review from not-using August 14, 2023 12:01
@scarf005 scarf005 temporarily deployed to development August 14, 2023 12:02 — with GitHub Actions Inactive
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path와 domain을 아예 변수로 빼서 인자로 넣어줌으로써 같은 값을 사용하게 변경하셨군요 :)

@scarf005 scarf005 merged commit 8699b51 into develop Aug 15, 2023
@scarf005 scarf005 deleted the logout branch August 15, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

로그아웃 후 access token 남는 문제
2 participants