-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 사서 대출권수 변경 #620
Open
hyeunkim42
wants to merge
18
commits into
develop
Choose a base branch
from
619-사서-대출권수-4권으로-변경
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "619-\uC0AC\uC11C-\uB300\uCD9C\uAD8C\uC218-4\uAD8C\uC73C\uB85C-\uBCC0\uACBD"
Open
feat: 사서 대출권수 변경 #620
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2a1079f
WIP
hyeunkim42 6655d5e
wip: Rending Confirm에서 사서가 자신의 책을 대출할 때 4권까지 대출 허용
hyeunkim42 426c95f
fix: 책을 2권 초과하여 선택하는 경우 삭제 대상만 리스트에 남아있는 버그 수정
hyeunkim42 1c10729
wip: 임시로 4권 선택 가능하도록 수정해둔 상태
hyeunkim42 6ea9ec7
fix: 사서인지 확인하는 변수를 prop이 아닌 userAtom으로 판단하도록 변경
hyeunkim42 afbbcbe
fix: 사서 본인의 대출인지 확인하는 방식을 prop에서 Atom으로 변경
hyeunkim42 b612710
feat: 대출 유저 선택 후, 사서라면 사서 표시 추가
mixsung 0b344a3
feat: 사서 본인의 대출 시, 4권까지 가능하도록 lendingLimit 설정
mixsung a24613f
feat: 사서 본인의 대출에 따라 바뀌는 대출현황(/2권 -> /4권)
mixsung 8e0e2ee
refactor: 대출확인모달의 선택 도서 간 경계 및 비고란 명확한 표시 추가
mixsung db632ed
fix: penalty 표시에 괄호 안닫히던 bug 수정
hyeunkim42 e56f1ff
fix: 책 비고 작성시 2~4번째 책 비고란 묶여있던 거 각각 작성되도록 수정
hyeunkim42 5de1deb
fix: 이전 커밋 적용 된 뒤 "대출하기" 버튼 안눌리던 현상 수정
hyeunkim42 314ccc3
fix: 유저의 role을 enum으로 변경 후 적용
mixsung ed99a11
fix: Rent 비즈니스 로직 변경(대출권수)을 JSDoc으로 명시
mixsung 702403f
fix: lendingLimit 함수화 및 constant 적용
mixsung c53f6fe
fix: 변수 이름 수정, lending limit 함수 사용
hyeunkim42 bd2e37b
fix: lendingLimit 함수화 적용
mixsung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSDoc을 통해 다른 파일에서도 비지니스 로직(사서만 4권)을 확인할 수 있도록 수정하면 유지보수하기 용이할 듯 합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다!