-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: main 배포 #625
Merged
Merged
ci: main 배포 #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
YeonSeong-Lee
commented
Oct 3, 2024
- 사서4권 대출
- 자동배포
listVideoInputDevices()로 불러들인 디바이스 중 사용불가능한 것을 목록에서 제거 카메라 변경시마다 reset()을 호출
fix: 바코드리더 사용불가디바이스 제거
ci: semantic PR 기준 완화
lendingLimit 변수의 값이 selectedUser가 librarian(현재 로그인한 유저)인 경우 4로 설정됨 - prop으로 넘겨받고 있는데, Atom 에서 받아와서 설정하도록 다시 변경해야함
setSelectedBooks내부에서 불러오는 함수를 splice에서 filter로 변경
Rent Modal User List와 Rent Inquire Box User 모두 연체인 경우만 괄호를 닫아주고 있어서 책 권수 초과에도 닫도록 조건 추가
remark(비고) array를 만들어서 selectedBooks의 index 이용하도록 설정
TextareaWithLabel에서 setState를 다시 생성해서 관리하고 있던 부분을 받아온 state를 이용하도록 변경
피드백 반영해서 1. 변수 이름을 librarian에서 currUser로 수정했습니다. 2. lending limit의 경우 constant 폴더의 status에서 가져와서 사용하도록 했습니다.
undefined 접근 에러를 예방하기 위해 옵셔널 체이닝을 추가합니다. 추후 필요에 따라 리팩토링과정에서 타입이 추가 될 수 있습니다.
feat: 사서 대출권수 변경
for prerendeing, SEO
…명-미리보기로-보여주기 feat: 책 링크 공유시 해당책에 이미지와 설명 미리보기로 보여주기
using codedeploy
ci: 자동배포용 스크립트
nyj001012
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.