Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Go 1.14, Add DatDog APM support and slight refactor #50

Merged
merged 38 commits into from
Mar 4, 2020
Merged

Move to Go 1.14, Add DatDog APM support and slight refactor #50

merged 38 commits into from
Mar 4, 2020

Conversation

jippi
Copy link
Owner

@jippi jippi commented Feb 28, 2020 •
edited
Loading

  • Add DataDog APM instrumentation
  • Refactored a bunch of internals to make it more easy to instrument
  • Upgraded to Go 1.14
  • DRY things up a ton

Signed-off-by: Christian Winther jippignu@gmail.com

@jippi
bump deps and add stuff
0e5540b 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi jippi self-assigned this Feb 28, 2020
@jippi
CGO back
ef59339 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
fix windows build
d815d69 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
start tracer
5a38d1e 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
logz
fe7599f 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
log spans
2523b21 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
remove dd prefix
9ed30e3 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
retain type of labels in logging
3955b85 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
use %v instead of %s
ce968bb 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
fix naming
dbe8865 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
only add trace_id and span_id to log, not to telemetry
3976461 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi jippi changed the title bump deps and add stuff Move to Go 1.14, Add DatDog APM support and slight refactor Feb 28, 2020
jippi added 17 commits March 4, 2020 11:08
@jippi
cleanup
1751990 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
Merge branch 'master' of github.com:jippi/go-metadataproxy into updat…
0000acf 
…e-go-and-mod

Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
fix casing
e976245 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
centralize log and telemetry logic
81fc30b 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
more DD refactoring
1cc2aac 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
Only set aws_api_version if applicable
741f713 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
more data to traces
1087fa9 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
skip DD keys in traces
cf42468 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
configure label separator
3981496 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
force Go 1.14
30085f6 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
more tracing party
b4bcbb6 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
link traces
d726f62 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
fix build+cache
cb75fb1 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
cache go mod
ec95f89 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
improve tracing
456ffd5 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
wrap roundtripper
e896ef5 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
trace AWS
8995fbf 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
wrap AWS correctly
3865ec4 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
wrap AWS correctly
833682e 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
rename stuff
830e6fe 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
context all the things
b67b4ef 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
name the service
af7d1ce 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
more naming
e5bfaa7 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
more trace error handling
511f1ef 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
dot all the things
e944631 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi
change more labels
cc2c16f 
Signed-off-by: Christian Winther <jippignu@gmail.com>
burdandrei
burdandrei approved these changes Mar 4, 2020
View reviewed changes
Copy link

@burdandrei burdandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jippi
fix label
ed9de44 
Signed-off-by: Christian Winther <jippignu@gmail.com>
@jippi jippi merged commit 3ac5ecc into master Mar 4, 2020
@jippi jippi deleted the update-go-and-mod branch March 4, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burdandrei burdandrei burdandrei approved these changes

Assignees

@jippi jippi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jippi @burdandrei