Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post debug extras #219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Post debug extras #219

wants to merge 2 commits into from

Conversation

paweldomas
Copy link
Member

This is two extra commits added on top of #218 but it's a big change and not sure if desired.

This allows to share session specific variables between session related
instances.
* The logger for this class
*/
private final static Logger logger
= Logger.getLogger(GoogleCloudTranscriptionService.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the logger name?

@Override
public void onCompleted()
{
for(TranscriptionListener listener : requestManager.getListeners())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be valuable to trace what listeners have been to stop or whether whether the list of listeners is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants