Debug logs #178
Debug logs #178
Conversation
| @Override | ||
| public List getBrowserLogs() | ||
| { | ||
| return (List)executeScript("return APP.debugLogs.getLogs();"); |
There was a problem hiding this comment.
can we try catch RuntimeException here and return empty List or null in case "APP" will be undefined ?
There was a problem hiding this comment.
also there's missing space after (List)
|
|
||
| return driver.manage().logs().get(LogType.BROWSER); | ||
| } | ||
| public abstract List getBrowserLogs(); |
There was a problem hiding this comment.
can we specify what kind of list that is ? List or whatever
There was a problem hiding this comment.
What is the point of having that?
There was a problem hiding this comment.
Because in one doc you write it's a string in other there can be just anything and it's not obvious what's there. It's just kind of self documenting, but you can leave it as is if you don't like that
There was a problem hiding this comment.
I just don't see the point of having that. If there is nothing it is Object.
There was a problem hiding this comment.
yeah, maybe I just got used to templates somehow
| { | ||
| return (List) executeScript("return APP.debugLogs.getLogs();"); | ||
| } | ||
| catch (Throwable t) |
There was a problem hiding this comment.
not Throwable, Exception at best, but ideally a RuntimeException
Depends on jitsi/jitsi-meet#2858