Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): build multiarch images #661

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

aaronkvanmeerten
Copy link
Member

No description provided.

sawall
sawall previously approved these changes Nov 7, 2024
damencho
damencho previously approved these changes Nov 7, 2024
@aaronkvanmeerten aaronkvanmeerten merged commit 08c93b4 into master Nov 7, 2024
5 checks passed
@aaronkvanmeerten aaronkvanmeerten deleted the grid-buildx-multi-arch branch November 7, 2024 22:29
@damencho
Copy link
Member

@aaronkvanmeerten Can you edit the README on how to build the images after these changes, as the current instructions end up with an error:

Step 3/11 : FROM --platform=$TARGETPLATFORM  selenium/standalone-${BROWSER}:${VERSION}
failed to parse platform : "" is an invalid component of "": platform specifier component must match "^[A-Za-z0-9_-]+$": invalid argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants