Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(media) Deprecate startScreenSharing config option for web browsers. #10846

Merged

Conversation

jallamsetty1
Copy link
Member

This is no longer supported as per the w3c spec for getDisplayMedia.

This is no longer supported as per the w3c spec for getDisplayMedia.
@jallamsetty1 jallamsetty1 merged commit 64322db into jitsi:master Jan 25, 2022
@jallamsetty1 jallamsetty1 deleted the deprecate-startScreenSharing branch January 25, 2022 20:05
@yyynnn
Copy link

yyynnn commented Mar 4, 2022

what it means?
that we cant start screen sharing dialog programmatically?
latest build breaks that behaviour

@saghul
Copy link
Member

saghul commented Mar 4, 2022

Correct. That's a browser limitation, not something we have control over, alas.

@ihcaesar
Copy link

Can you revert this change to make at least Chrome/Edge work again?

The discussion under w3c/mediacapture-screen-share-extensions#11 is still open.
Still open also:
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1724865
Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1198918

The Chrome bug may be solved without breaking "top-level transient activation", which is considered as interim option in the open Firefox bug report. The consider option with capability delegation is not implementend in Chrome and Firefox.

So, as interim solution, I'd propose to revert this change or make it user-agent dependant - so we can use this option with Chrome/Edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants