fix(recordings) disable default auto transcribe #14495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihhu
force-pushed
the
auto-transcribe-recordings-off
branch
from
7e4eb45 to
cb6467c
Compare
saghul
reviewed
Mar 18, 2024
| @@ -208,7 +208,7 @@ export function canStopRecording(state: IReduxState) { | |||
| export function shouldAutoTranscribeOnRecord(state: IReduxState) { | |||
| const { transcription } = state['features/base/config']; | |||
|
|
|||
| return transcription?.autoTranscribeOnRecord ?? true; | |||
| return Boolean(transcription?.autoTranscribeOnRecord && canAddTranscriber(state)); | |||
There was a problem hiding this comment.
Make autoTranscribeOnRecord default o true though.
mihhu
force-pushed
the
auto-transcribe-recordings-off
branch
from
cb6467c to
95bf2f6
Compare
mihhu
force-pushed
the
auto-transcribe-recordings-off
branch
from
95bf2f6 to
ab0fe72
Compare
saghul
approved these changes
Mar 18, 2024
mihhu
added a commit
to mihhu/jitsi-meet
that referenced
this pull request
Mar 18, 2024
mihhu
added a commit
that referenced
this pull request
Mar 18, 2024
yanas
pushed a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.