Add datachannel support for relay message transport. #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
============================================
- Coverage 43.10% 43.03% -0.07%
- Complexity 1672 1677 +5
============================================
Files 323 325 +2
Lines 16740 16888 +148
Branches 2202 2227 +25
============================================
+ Hits 7215 7267 +52
- Misses 8814 8910 +96
Partials 711 711
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…channels in the signaling.
|
See also jitsi/jicofo#1051 |
bgrozev
reviewed
Mar 13, 2023
jvb/src/main/kotlin/org/jitsi/videobridge/colibri2/Colibri2ConferenceHandler.kt
Show resolved
Hide resolved
bgrozev
reviewed
Mar 13, 2023
| @@ -76,13 +75,6 @@ class Colibri2ConferenceHandler( | |||
| if (!RelayConfig.config.enabled) { | |||
| throw IqProcessingException(Condition.feature_not_implemented, "Octo is disable in configuration.") | |||
| } | |||
| if (!WebsocketServiceConfig.config.enabled) { | |||
There was a problem hiding this comment.
Should we still throw if neither SCTP nor websockets are enabled?
bgrozev
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.