Add meshId to debug state. #2009
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2009 +/- ##
============================================
- Coverage 42.91% 42.86% -0.05%
+ Complexity 1678 1674 -4
============================================
Files 325 325
Lines 16942 16945 +3
Branches 2237 2238 +1
============================================
- Hits 7270 7264 -6
- Misses 8961 8969 +8
- Partials 711 712 +1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -301,6 +301,7 @@ class Relay @JvmOverloads constructor( | |||
| put("iceTransport", iceTransport.getDebugState()) | |||
| put("dtlsTransport", dtlsTransport.getDebugState()) | |||
| put("transceiver", transceiver.getNodeStats().toJson()) | |||
| put("meshId", meshId.toString()) | |||
There was a problem hiding this comment.
Doesn't this do "meshId": "null" if there's no meshId? If this is json unquoted null is probably ok, but quoted null would be confusing (since that's technically a valid meshId value).
There was a problem hiding this comment.
I did this on purpose because I have a vague memory of something down the line breaking if we have null values. But I think I may be getting confused with OrderedJsonObject which requires non-nulls but isn't used here.
No description provided.