Call conference.addEndpoints() a single time when adding RelayedEndpoints. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -733,18 +733,19 @@ class Relay @JvmOverloads constructor( | |||
| fun dtlsAppPacketReceived(data: ByteArray, off: Int, len: Int) = | |||
| sctpHandler.processPacket(PacketInfo(UnparsedPacket(data, off, len))) | |||
|
|
|||
| /** Return the newly created endpoint, or null if an endpoint with that ID already existed. */ | |||
There was a problem hiding this comment.
Maybe add a note here that this does not add it to the conference?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
============================================
+ Coverage 42.91% 42.95% +0.04%
- Complexity 1678 1681 +3
============================================
Files 325 325
Lines 16942 16944 +2
Branches 2237 2238 +1
============================================
+ Hits 7270 7279 +9
+ Misses 8961 8947 -14
- Partials 711 718 +7
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
JonathanLennox
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.