Add support for the VLA RTP header extension #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Dec 12, 2024
bgrozev
commented
- feat: Add BitReader utilities and tests.
- feat: Add a parser for the VLA RTP header extension.
- ref: Remove unused function.
- feat: Update layers with info found in VLA.
- feat: Add an option to use targetBitrate instead of measured bitrate for allocation
| ) | ||
| ) | ||
| } | ||
| context("VP9 SVC (witt resolutions)") { |
| ) | ||
| } | ||
| context("Invalid VLAs") { | ||
| parse(0x00) shouldBe emptyList() |
There was a problem hiding this comment.
Do we want to do anything to log about invalid VLAs?
| if (layer.height > 0 && layer.height != res.height) { | ||
| logger.warn("Updating layer height from ${layer.height} to ${res.height}") | ||
| } | ||
| if (layer.frameRate > 0.0 && layer.frameRate != res.maxFramerate.toDouble()) { |
There was a problem hiding this comment.
I feel like this one's likely to trigger a lot in practice, have you looked for it?
JonathanLennox
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.