Skip to content

Commit

Permalink
sync-sidecar: fix a bug that could mark sync with errors as fully suc…
Browse files Browse the repository at this point in the history
…cessful
  • Loading branch information
absorbb committed Aug 16, 2024
1 parent 9c4ae1c commit 5b16093
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sync-sidecar/read.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (s *ReadSideCar) Run() {
s.registerErr(fmt.Errorf("%v", r))
s.closeActiveStreams(false)
} else {
s.closeActiveStreams(!cancelled)
s.closeActiveStreams(!cancelled && !s.isErr())
}
if len(s.processedStreams) > 0 {
statusMap := types2.NewOrderedMap[string, any]()
Expand Down

0 comments on commit 5b16093

Please sign in to comment.