feat: remove write key from payload event when sending it to segment #1143
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
SegmentDestination
function inlibs/core-functions/src/functions/segment-destination.ts
. The change ensures that thewriteKey
is removed from the event payload before sending the HTTP request.libs/core-functions/src/functions/segment-destination.ts
: Added a new constanteventWithoutWriteKey
to create a copy of the event with thewriteKey
set tonull
and updated thehttpRequest
payload to use this new constant.Why?
We are moving away from Segment API and using jitsu to send our events on our website, but we had to create a function to remove the write key that jitsu tries to send to segment, because it's unnecessary and does not work without the function.
Function:
Example of what happens if we don't use that function: