fix(cache): cache key comparison ignores milliseconds #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #489. The comparison used for cache keys ignores milliseconds, leading to false positive cache hits.
In this PR I've changed the comparison strategy to compare the unix timestamps of the relevant dates instead. Let me know whether you think this is the right approach :)
Thanks for contributing to
rrule
!To submit a pull request, please verify that you have done the following:
master
commitaddressing